Skip to content

Bump cilium to 1.18.5 #17833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ameukam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump cilium to 1.18.5 #17833

ameukam wants to merge 1 commit into from
+100 −314

Conversation

@ameukam
Copy link
Member

@ameukam ameukam commented Dec 19, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/addons labels Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2025
@hakman
Copy link
Member

hakman commented Dec 19, 2025

Hmm, not sure what happened to the template.
/lgtm cancel
/approve cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2025
hakman
hakman reviewed Dec 19, 2025
View reviewed changes
upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.16-v1.15.yaml.template
metadata:
name: "cilium-operator"
namespace: kube-system
{{ if WithDefaultBool .Hubble.Enabled false }}
Copy link
Member

@hakman hakman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam There should be no changes to the .template file.

Copy link
Member Author

@ameukam ameukam Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran helm template --release-name cilium cilium/cilium --version 1.18.5 --namespace kube-system --values helm-values.yaml > k8s-1.16-v1.15.yaml.template to get this. Am I wrong ?

Copy link
Member

@hakman hakman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just informative, our template is much more complicated.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 19, 2025

@ameukam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test 4cd0098 link true /test pull-kops-test
pull-kops-e2e-k8s-gce-cilium 4cd0098 link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-azure-cni-cilium 4cd0098 link true /test pull-kops-e2e-azure-cni-cilium
pull-kops-e2e-gce-cni-cilium 4cd0098 link false /test pull-kops-e2e-gce-cni-cilium
pull-kops-e2e-cni-cilium-etcd 4cd0098 link true /test pull-kops-e2e-cni-cilium-etcd
pull-kops-e2e-cni-cilium-eni 4cd0098 link true /test pull-kops-e2e-cni-cilium-eni
pull-kops-e2e-cni-cilium-ipv6 4cd0098 link false /test pull-kops-e2e-cni-cilium-ipv6
pull-kops-e2e-cni-cilium 4cd0098 link true /test pull-kops-e2e-cni-cilium
pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons 4cd0098 link false /test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
pull-kops-e2e-k8s-gce-ipalias 4cd0098 link true /test pull-kops-e2e-k8s-gce-ipalias

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

Assignees

@hakman hakman

Labels

area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ameukam @hakman @k8s-ci-robot