-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eventhandler): trigger Node/Delete event #127464
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@alculquicondor also, do we want to cherry-pick this? |
/lgtm |
LGTM label has been added. Git tree hash: 46834776b54969e504483c58f7867b2ecf7cb157
|
@@ -134,6 +134,8 @@ func (sched *Scheduler) deleteNodeFromCache(obj interface{}) { | |||
return | |||
} | |||
|
|||
sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(logger, framework.NodeDelete, node, nil, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the event doesn't seem to be used anywhere.
In any case, we should add a test, preferably integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an integration test in #127387
func TestUnscheduledPodEvents(t *testing.T) { |
These two pr are a little similar, #127387 trigger unscheduledPod add/update//delete event, while this one triggers node/delete event.
Maybe the integration test in #127387 can be more general and we can reuse it here.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We didn't trigger Node/Delete event at all...
Which issue(s) this PR fixes:
Initially found at #110175 (comment), but we forgot to fix.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: