-
Notifications
You must be signed in to change notification settings - Fork 42k
Fix data race in PriorityQueue.UnschedulablePods() #135862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The UnschedulablePods() function iterates over the unschedulablePods.podInfoMap without holding any lock, while other goroutines may concurrently modify the map via addOrUpdate(), delete(), or clear(). Other functions like PendingPods() and GetPod() correctly acquire p.lock.RLock() before accessing unschedulablePods.podInfoMap, but UnschedulablePods() was missing this. Fix by adding p.lock.RLock()/RUnlock() to UnschedulablePods(), matching the pattern used by PendingPods().
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @grandeit. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grandeit The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The
UnschedulablePods()function iterates over theunschedulablePods.podInfoMapwithout holding any lock, while other goroutines may concurrently modify the map viaaddOrUpdate(),delete(), orclear().Other functions like
PendingPods()andGetPod()correctly acquirep.lock.RLock()before accessingunschedulablePods.podInfoMap, butUnschedulablePods()was missing this.Fix by adding
p.lock.RLock()/RUnlock()toUnschedulablePods(), matching the pattern used byPendingPods().What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR is related to:
Fixes: #135861
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: