-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Test/remove duplicate k8s versions #21501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test/remove duplicate k8s versions #21501
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vineetxkhurana The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @vineetxkhurana! |
Hi @vineetxkhurana. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
This PR refactors Kubernetes version handling in integration tests by adding a helper function (GetKubernetesTestVersions) to
helpers_test.go
. The function ensures a unique, deduplicated list of Kubernetes versions for testing, so tests aren’t run multiple times for the same version. Theaaa_download_only_test.go
is updated to use this helper.Why this change?
Previously, tests could run redundantly if
DefaultKubernetesVersion
andNewestKubernetesVersion
were the same, leading to duplicate test runs.What did I change?
Added GetKubernetesTestVersions() to
test/integration/helpers_test.go
.Updated
test/integration/aaa_download_only_test.go
to use the new helper.Reference:
Addresses issue #21483.