Skip to content

CI: fix golangci-lint v2.12.2 update#22976

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/update-golint-version-to-v2-12-2
Draft

CI: fix golangci-lint v2.12.2 update#22976
Copilot wants to merge 2 commits into
masterfrom
copilot/update-golint-version-to-v2-12-2

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

Updating GOLINT_VERSION to v2.12.2 failed in CI because the upstream installer no longer verified the correct checksum entry for the release tarball. This updates minikube's install path for golangci-lint and clears the new govet findings introduced by v2.12.2.

  • Installer path

    • Replace the install.sh pipe in Makefile with direct download of the release tarball and checksums file.
    • Verify the archive against the checksum entry matched by exact filename, then extract the binary into out/linters.
  • Lint compatibility

    • Replace the small set of ioutil calls now flagged by govet with the equivalent os/io APIs in pkg/libmachine/....
    • Keep behavior unchanged while making the tree clean under golangci-lint v2.12.2.
  • Key change

    want=$$(awk -v file="$${name}.tar.gz" '$$2 == file { print $$1; exit }' "$${checksums}")
    got=$$(openssl sha256 "$${archive}" | awk '{print $$2}')
    test "$${want}" = "$${got}"

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2026
Copilot AI linked an issue May 11, 2026 that may be closed by this pull request
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Copilot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Agent-Logs-Url: https://github.com/kubernetes/minikube/sessions/ec0e0b7b-d44d-4109-8134-5ccc561e3540

Co-authored-by: medyagh <4564227+medyagh@users.noreply.github.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from medyagh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2026
Copilot AI changed the title [WIP] Fix golint update from v2.11.4 to v2.12.2 CI: fix golangci-lint v2.12.2 update May 11, 2026
Copilot AI requested a review from medyagh May 11, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

updating golint from v2.11.4 to v2.12.2 fails

4 participants