-
Notifications
You must be signed in to change notification settings - Fork 607
Add measurement to check memory usage in benchmark list job #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add measurement to check memory usage in benchmark list job #3574
Conversation
Hi @arshadd-b. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
clusterloader2/pkg/measurement/common/container_memory_usage.go
Outdated
Show resolved
Hide resolved
f95b7b9
to
fb3e5aa
Compare
action: {{$action}} | ||
{{if $ENABLE_CONTAINER_MEMORY_USAGE_MEASUREMENT}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
fb3e5aa
to
df460c1
Compare
df460c1
to
26bed73
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arshadd-b, serathius The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It might take a day or two to get review, unfortunately @mborsz is busy at the moment. |
What type of PR is this?
What this PR does / why we need it:
Adds new measurement to check apiserver memory limit below threshold in list benchmark job.
Which issue(s) this PR fixes:
Fixes # kubernetes/kubernetes#131885
Special notes for your reviewer: