Skip to content

Conversation

arshadd-b
Copy link

What type of PR is this?

What this PR does / why we need it:

Adds new measurement to check apiserver memory limit below threshold in list benchmark job.

Which issue(s) this PR fixes:

Fixes # kubernetes/kubernetes#131885

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mborsz September 4, 2025 08:42
@k8s-ci-robot
Copy link
Contributor

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 4, 2025
@arshadd-b
Copy link
Author

Have tested the list benchmark job

Failure case
Screenshot 2025-09-04 at 2 24 10 PM

success case
Screenshot 2025-09-04 at 2 26 20 PM

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2025
@arshadd-b arshadd-b force-pushed the add-container-mem-usage-measurement branch 2 times, most recently from f95b7b9 to fb3e5aa Compare September 8, 2025 13:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2025
action: {{$action}}
{{if $ENABLE_CONTAINER_MEMORY_USAGE_MEASUREMENT}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@arshadd-b arshadd-b force-pushed the add-container-mem-usage-measurement branch from fb3e5aa to df460c1 Compare September 9, 2025 04:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2025
@arshadd-b
Copy link
Author

have tested the changes
Success case

Screenshot 2025-09-08 at 6 38 19 PM Failure case Screenshot 2025-09-08 at 6 39 04 PM

@arshadd-b arshadd-b requested a review from serathius September 9, 2025 04:49
@arshadd-b arshadd-b force-pushed the add-container-mem-usage-measurement branch from df460c1 to 26bed73 Compare September 9, 2025 04:50
@arshadd-b arshadd-b requested a review from serathius September 10, 2025 05:54
@arshadd-b arshadd-b requested a review from serathius September 10, 2025 10:42
@serathius
Copy link
Contributor

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arshadd-b, serathius
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

/cc @mborsz @wojtek-t

@serathius
Copy link
Contributor

It might take a day or two to get review, unfortunately @mborsz is busy at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants