Skip to content

Fix Framework.{Patch,Delete,Get}Object methods not passing APICallOptions to the underlying client methods #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Framework.{Patch,Delete,Get}Object methods not passing APICallOptions to the underlying client methods #3576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions clusterloader2/pkg/framework/framework.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,18 +255,18 @@ func (f *Framework) CreateObject(namespace string, name string, obj *unstructure
}

// PatchObject updates object (using patch) with given name using given object description.
func (f *Framework) PatchObject(namespace string, name string, obj *unstructured.Unstructured, _ ...*client.APICallOptions) error {
return client.PatchObject(f.dynamicClients.GetClient(), namespace, name, obj)
func (f *Framework) PatchObject(namespace string, name string, obj *unstructured.Unstructured, options ...*client.APICallOptions) error {
return client.PatchObject(f.dynamicClients.GetClient(), namespace, name, obj, options...)
}

// DeleteObject deletes object with given name and group-version-kind.
func (f *Framework) DeleteObject(gvk schema.GroupVersionKind, namespace string, name string, _ ...*client.APICallOptions) error {
return client.DeleteObject(f.dynamicClients.GetClient(), gvk, namespace, name)
func (f *Framework) DeleteObject(gvk schema.GroupVersionKind, namespace string, name string, options ...*client.APICallOptions) error {
return client.DeleteObject(f.dynamicClients.GetClient(), gvk, namespace, name, options...)
}

// GetObject retrieves object with given name and group-version-kind.
func (f *Framework) GetObject(gvk schema.GroupVersionKind, namespace string, name string, _ ...*client.APICallOptions) (*unstructured.Unstructured, error) {
return client.GetObject(f.dynamicClients.GetClient(), gvk, namespace, name)
func (f *Framework) GetObject(gvk schema.GroupVersionKind, namespace string, name string, options ...*client.APICallOptions) (*unstructured.Unstructured, error) {
return client.GetObject(f.dynamicClients.GetClient(), gvk, namespace, name, options...)
}

// ApplyTemplatedManifests finds and applies all manifest template files matching the provided
Expand Down