use google/safetext for yaml templating.

[hoskeri]

I think krel is used only with trusted inputs.

However, this should be a safe drop in replacement that blocks yaml injection attacks via package metadata templates.

/kind cleanup

What this PR does / why we need it:

use google/safetext (a drop-in replacement for text/template) to generate yaml.
This prevents certain yaml injection attacks.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Welcome @hoskeri!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @hoskeri. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cpanato]

/ok-to-test

[cpanato]

Thanks for the PR.
I was looking at the project, and it seems it is not actively maintained, and the last commit was in Jan/2023. Not sure, to be honest. Let's check the feeling of others

cc @saschagrunert @jeremyrickard @xmudrii @Verolop @puerco @ameukam @kubernetes/release-managers

[saschagrunert]

I'm also a bit on the fence with this change. On one side I like the additional security (preventing yaml injections), but on the other side it does not seem to be an official google project (but in the google org?).

Kind is using it since the merge of kubernetes-sigs/kind#2911

[cpanato]

@saschagrunert If Kind is using i guess we can follow and use it as well

@hoskeri can you rebase and fix the conflicts? thanks

[hoskeri]

/retest

[hoskeri]

that failed cause of a timeout reading the git repo?
let's try again.

/test pull-release-integration-test

[cpanato]

/hold

need to fix some lints errors @hoskeri

[hoskeri]

@saschagrunert If Kind is using i guess we can follow and use it as well

@hoskeri can you rebase and fix the conflicts? thanks

Done, thanks! The tests are now passing.

[hoskeri]

/hold

need to fix some lints errors @hoskeri

fixed!

[hoskeri]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoskeri, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hoskeri]

@cpanato I think the hold can be removed: I've fixed the linter errors.

[xmudrii]

/hold cancel