Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3866 nftables kube-proxy to GA #49453

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

danwinship
Copy link
Contributor

Description

update NFTablesProxyMode feature gate info for 1.33

I wasn't sure if I was supposed to remove the line:

{{< feature-state feature_gate_name="NFTablesProxyMode" >}}

from content/en/docs/reference/networking/virtual-ips.md or not?

Also, the existing note

As of Kubernetes {{< skew currentVersion >}}, the `nftables` mode is
still relatively new, and may not be compatible with all network
plugins; consult the documentation for your network plugin.

still seems true for now, so I didn't remove it.

Issue

kubernetes/enhancements#3866

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5290e19
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67aa3af55ea1780008534a07

Copy link

netlify bot commented Jan 15, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5290e19
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67aa3af5c3b9bc0008619f50
😎 Deploy Preview https://deploy-preview-49453--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2025
@danwinship danwinship marked this pull request as ready for review February 10, 2025 17:44
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 10, 2025
@aojea
Copy link
Member

aojea commented Mar 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de761aa661b5e6baf844208d90355ac04b2fe663

@aojea
Copy link
Member

aojea commented Mar 24, 2025

/lgtm
/approve

@tengqm
Copy link
Contributor

tengqm commented Mar 24, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit e63cc33 into kubernetes:dev-1.33 Mar 24, 2025
6 checks passed
@danwinship danwinship deleted the nftables-ga branch March 24, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants