Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon]: add fluxcd kustomize healthcheck #681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

workman-Lu
Copy link

This PR adds a health-check feature to the addon.

Testing has not been mentioned in the PR.

Checklist
[x] Updated the version in the addon’s metadata file to generate a new version.

--version 2.3.5

@wangyikewxgm
Copy link
Collaborator

Great job! Thank you for your first contribution. Here are a few pieces of advice::

  1. Please make sure to sign the DCO to pass the check of your PR.
  2. It would be great if you could add a test case for the kustomize component, similar to the: https://github.com/kubevela/catalog/blob/master/test/e2e-test/addon-test/definition-test/testdata/fluxcd/helm-component.yaml

and flow details.

[Addon]: add fluxcd kustomize healthcheck ,customStatus.
Kustomize flow details.

[Addon]: add fluxcd kustomize healthcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants