Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] velaux allow a custom ingress class name #741

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

oanasc
Copy link
Contributor

@oanasc oanasc commented Nov 24, 2023

Description of your changes

Fixes ##739

How has this code been tested?

Enabled the modified addon locally and ensured I can specify the gatewayDriver with a custom name and that is correctly used in the ingressClass annotation the ingress works.

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@@ -23,7 +23,7 @@ _nginxTrait: *[
http: {
"/": 8000
}
class: "nginx"
class: parameter["ingressClass"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can reuse the gatewayDriver field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, updated to use gatewayDriver and works on my cluser. The e2e test however is timing out, seeing why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because the version of the addon is also used for the image tag, do you prefer creating a new tag v1.9.4 or parameterising the image tag and allow for addons upgrades independently from velaux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlie0129 what do you think. I get is nice for the tag/version of addon to map but in reality there can be addon changes with not image release

@oanasc oanasc changed the title velaux ingress expose ingress class name parameter [Addon] velaux allow a custom ingress class name Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants