-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon] velaux allow a custom ingress class name #741
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Oana Schipor <[email protected]>
addons/velaux/resources/server.cue
Outdated
@@ -23,7 +23,7 @@ _nginxTrait: *[ | |||
http: { | |||
"/": 8000 | |||
} | |||
class: "nginx" | |||
class: parameter["ingressClass"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can reuse the gatewayDriver field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, updated to use gatewayDriver and works on my cluser. The e2e test however is timing out, seeing why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing because the version of the addon is also used for the image tag, do you prefer creating a new tag v1.9.4 or parameterising the image tag and allow for addons upgrades independently from velaux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlie0129 what do you think. I get is nice for the tag/version of addon to map but in reality there can be addon changes with not image release
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
Description of your changes
Fixes ##739
How has this code been tested?
Enabled the modified addon locally and ensured I can specify the gatewayDriver with a custom name and that is correctly used in the ingressClass annotation the ingress works.
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml
.README.md
.