-
Notifications
You must be signed in to change notification settings - Fork 14
WIP: Builder: Improve build process for builder image #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Move all files for building the image under hack/build/builder. Remove unused output-bazel-arch.sh file. Make build scripts more similiar to kubevirt scripts. Do not use buildah but instead support docker/podman. Build multiarch image by default. Gatekeeping when a new image is built will happen in project-infra. This allow the build script to be more easily used for local development. Expand the provided builder image architectures by adding s390x. Signed-off-by: Jan Schintag <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I have created this as a draft, since in local testing i have experienced it hanging already. So currently i'm debugging. |
|
As best as i can determine, the processes simply sleep forever: This is currently hanging since yesterday at Though it does not seem to matter at which point package it hangs. |
interesting observation |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Move all files for building the image under hack/build/builder. Remove unused output-bazel-arch.sh file.
Make build scripts more similiar to kubevirt scripts. Do not use buildah but instead support docker/podman. Build multiarch image by default.
Gatekeeping when a new image is built will happen in project-infra. This allow the build script to be more easily used for local development. Expand the provided builder image architectures by adding s390x.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This needed to be reverted already once, as the build would randomly hang (#145).
/cc @Barakmor1
Release note: