[release-1.14] Downgrade AAQ to v1.3.0 #3911
Conversation
We can't compile with AAQ 1.3.1 in openshift CI, as go1.22 there is 1.22.9, while AAQ requires 1.22.11 Signed-off-by: Nahshon Unna Tsameret <[email protected]>
Signed-off-by: machadovilaca <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new
getAlertmanagerRouteHosthelper assumes the firstStatus.Ingressentry is valid; consider iterating to find an admitted/ready ingress or at least checking conditions to avoid flaky tests when routes are partially configured. - The alertmanager route name and namespace are currently hardcoded in
getAlertmanagerRouteHost; consider extracting them into constants or reusing existing configuration so they stay in sync with any future changes to the alertmanager deployment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `getAlertmanagerRouteHost` helper assumes the first `Status.Ingress` entry is valid; consider iterating to find an admitted/ready ingress or at least checking conditions to avoid flaky tests when routes are partially configured.
- The alertmanager route name and namespace are currently hardcoded in `getAlertmanagerRouteHost`; consider extracting them into constants or reusing existing configuration so they stay in sync with any future changes to the alertmanager deployment.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 20006345561Details
💛 - Coveralls |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
We can't compile with AAQ 1.3.1 in openshift CI, as go1.22 there is 1.22.9, while AAQ requires 1.22.11
Also, this PR modifies the e2e test to use OpenShift Route to communicate with the Alertmanager .
Release note: