Skip to content

[release-v0.22] tests: Fixed incorrect test that depended on undefined env variable #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubevirt-bot merged 1 commit into from
Feb 16, 2026
+29 −2
Merged

[release-v0.22] tests: Fixed incorrect test that depended on undefined env variable #1679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions tests/service_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@ package tests
import (
"fmt"
"reflect"
"slices"
"time"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -44,10 +46,35 @@ var _ = Describe("Service Controller", func() {
service, serviceErr := getSspMetricsService()
Expect(serviceErr).ToNot(HaveOccurred(), "Failed to get ssp-operator-metrics service")

deployment := &apps.Deployment{}
Expect(apiClient.Get(ctx, types.NamespacedName{
Name: strategy.GetSSPDeploymentName(),
Namespace: strategy.GetSSPDeploymentNameSpace(),
}, deployment)).To(Succeed())

containers := deployment.Spec.Template.Spec.Containers
id := slices.IndexFunc(containers, func(container v1.Container) bool {
return container.Name == "manager"
})
Expect(id).ToNot(Equal(-1), "SSP deployment does not contain manager container")

envId := slices.IndexFunc(containers[id].Env, func(envVar v1.EnvVar) bool {
return envVar.Name == sspenv.OperatorVersionKey
})
Expect(envId).ToNot(Equal(-1), "SSP manager container does not have the operator version variable")

version := containers[id].Env[envId].Value
if version != "" {
Expect(service.GetLabels()).To(HaveKeyWithValue(common.AppKubernetesVersionLabel, version))
} else {
// If the version env variable is not defined, then it is not simple to get the version from test code.
Expect(service.GetLabels()).To(HaveKey(common.AppKubernetesVersionLabel))
}

Expect(service.GetLabels()).To(HaveKeyWithValue(common.AppKubernetesManagedByLabel, controllers.ServiceManagedByLabelValue))
Expect(service.GetLabels()).To(HaveKeyWithValue(common.AppKubernetesVersionLabel, sspenv.GetOperatorVersion()))
Expect(service.GetLabels()).To(HaveKeyWithValue(common.AppKubernetesComponentLabel, controllers.ServiceControllerName))
Expect(service.GetLabels()[common.AppKubernetesPartOfLabel]).To(BeEmpty())
// Not using HaveKeyWithValue, because the label does not need to exist.
Expect(service.GetLabels()[common.AppKubernetesPartOfLabel]).To(Equal(deployment.Labels[common.AppKubernetesPartOfLabel]))
})

It("[test_id: 8808] Should re-create ssp-operator-metrics service if deleted", func() {
Expand Down