Bugfix: parse more query cases such as array input#4
Merged
Conversation
astrialyanda
force-pushed
the
bugfix/parse-query
branch
from
0c486eb to
e01ad07
Compare
astrialyanda
force-pushed
the
bugfix/parse-query
branch
from
e01ad07 to
8b50ae4
Compare
atjhoendz
reviewed
Dec 10, 2025
|
|
||
| assert.Error(t, err) | ||
| }) | ||
| // ignored since existing real cases such as directives is valid with the assumed incorrect separator |
Contributor
Author
There was a problem hiding this comment.
better kuhapus aja kah mas?
Member
There was a problem hiding this comment.
ini aslinya return error kan? jadi ga return error? diubah assertnya aja tp dikasih komen penjelasan kenapa
atjhoendz
reviewed
Dec 10, 2025
|
|
||
| s, _ := l.Parse() | ||
|
|
||
| // assert.NoError(t, err) |
Contributor
Author
There was a problem hiding this comment.
errornya ttp masuk mas tp namanya ttp dapet
Member
There was a problem hiding this comment.
assert error aja kalo gitu tp dikasih komen juga
aslamhadi
reviewed
Dec 11, 2025
| }) | ||
|
|
||
| t.Run("json with text", func(t *testing.T) { | ||
| l := Lexer{input: "mutation {\n\tAnalyzeTypo(texts: [\n \"GuluGuluGleg Gleg Gleg Khhrkkkrrrhrhhhrkkk\",\n \"Lorem ipsum dolor sit amet, elit\",\n \"roin maximus lectus ut turpis semper, vel blandit est accumsan.\",\n \"Quisque faucibus, dui eu suscipit condimentum, sapien ante tincidunt ipsum, vitae aliquam elit odio quis arcu.\",\n \"Donec aliquet tristique elit ut euismod\",\n \"Proin ut urna eget mi euismod auctor.\",\n \"The framework of thinking or rationale and research gaps that will be examined and contributed the results of research on solving problems related to coastal area management, especially development of technology for restoration and rehabilitation of mangrove ecosystems (personal documentation).\",\n\t]) {\n\t\ttypos{\n\t\t\toffset\n\t\t\ttype\n\t\t\ttoken\n\t\t\tsuggestions {\n\t\t\t\ttoken\n\t\t\t\tscore\n\t\t\t}\n\t\t}\n\t\t\n\t}\n}"} |
There was a problem hiding this comment.
kayak lagi keselek 😂 GuluGuluGleg Gleg Gleg Khhrkkkrrrhrhhhrkkk
aslamhadi
approved these changes
Dec 11, 2025
zhenqianz
approved these changes
Dec 11, 2025
atjhoendz
approved these changes
Dec 11, 2025
astrialyanda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.