Fix issue with color widget defaulting to black for named colors#70
Open
mdanse wants to merge 1 commit intokvesteri:masterfrom
Open
Fix issue with color widget defaulting to black for named colors#70mdanse wants to merge 1 commit intokvesteri:masterfrom
mdanse wants to merge 1 commit intokvesteri:masterfrom
Conversation
…olors The HTML5 color input only works with long hexadecimal color notation. When converting a Color object to string, the colour package will automatically convert to the smallest possible web format including named colors and short hex notation, resulting in the default black color in the color widget. This change forces the value to be written in long hex format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color input only works with long hexadecimal color notation. When converting a Color object to string, the colour package will automatically convert to the smallest possible web format including named colors and short hex notation, resulting in the default black color in the color widget. This change forces the value to be written in long hex format.