Add delete_file method to Koha::File::Transport and all subclasses #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and subclasses Introduce a new delete_file interface to all Koha::File::Transport subclasses to support file deletion over all supported transport types. This change is needed to provide a unified way to delete files on remote or local storage within Koha's file transport abstraction. - Add delete_file method to Koha::File::Transport as abstract interface - Implement delete_file in Local, FTP, and SFTP subclasses - Integrate robust error handling and success logging for deletions - Expand tests to cover delete_file, including file system checks This adds an important capability for automation and maintenance tasks using Koha's file management framework.
|
(Automated Close) Please do not file pull requests here, this repo is merely a clone of https://git.koha-community.org/Koha-community/Koha and we use Bugzilla at https://bugs.koha-community.org to submit patches to its codebase.\n\nSee https://wiki.koha-community.org/wiki/Submitting_A_Patch for more information. Note that you can use to easily set-up a full development environment, which includes the command to easily push your patches with a single command, instead of manually fiddling with patch files!\n\nIf you have any more questions or need help, do not hesitate to ask in our Mattermost chat: https://chat.koha-community.org. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new unified
delete_filemethod to the Koha::File::Transport class and all its subclasses, enabling safe and consistent file deletion for all supported transport types.Details
delete_filemethod toKoha::File::Transport.delete_filelogic for SFTP, FTP, and Local transports, including robust error and success reporting.Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup