Reuse identical parameters in supported dialects#1713
Open
Eyal-Shalev wants to merge 1 commit intokysely-org:masterfrom
Open
Reuse identical parameters in supported dialects#1713Eyal-Shalev wants to merge 1 commit intokysely-org:masterfrom
Eyal-Shalev wants to merge 1 commit intokysely-org:masterfrom
Conversation
|
@Eyal-Shalev is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
Eyal-Shalev
force-pushed
the
reuse-identical-parameters
branch
from
8cf28cf to
eb188d8
Compare
Eyal-Shalev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1387
Updated
DefaultQueryCompiler.appendValueto try searching for existing parameter placeholder before adding new parameters.getExistingParameterPlaceholdercan be overridden to update the placeholder syntax or to disable the functionality (sqlite and mysql don't support this)Added a test to verify it works correctly