fix: use file specifiers for absolute paths in file-migration-provider#1715
Open
crowlKats wants to merge 1 commit intokysely-org:masterfrom
Open
fix: use file specifiers for absolute paths in file-migration-provider#1715crowlKats wants to merge 1 commit intokysely-org:masterfrom
crowlKats wants to merge 1 commit intokysely-org:masterfrom
Conversation
|
@crowlKats is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Author
|
hmm i am surprised tests in node are failing; it does support file specifiers in |
igalklebanov
force-pushed
the
file-migration-provider-deno-jsr-fix
branch
from
5f0c0c9 to
4424eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for Deno + JSR, as because an absolute path inside a JSR package in Deno refers to the root of the JSR server, not of the system being run on. Specifying that its a file path ensures that this works as expected in Deno.