Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 100% 97.77% -2.23%
==========================================
Files 3 3
Lines 87 90 +3
Branches 9 10 +1
==========================================
+ Hits 87 88 +1
- Misses 0 1 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 97.77%
=========================================
Files ? 3
Lines ? 90
Branches ? 10
=========================================
Hits ? 88
Misses ? 1
Partials ? 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, - I needed a method to add the request object to the call to get_or_create_for_cognito. I saw in one of the other pull requests this was also added.
I've created a crude system to do this, now I can receive from this library with
def get_or_create_for_cognito(self, jwt_payload, request):
in my manager model.
I am open to helping any suggestions to doing this in a better/cleaner way. (I'm also quite new to python packaging and its tooling..)