Update tests and documentation to show that multiple audiences are supported#28
Open
skison wants to merge 1 commit intolabd:masterfrom
Open
Update tests and documentation to show that multiple audiences are supported#28skison wants to merge 1 commit intolabd:masterfrom
skison wants to merge 1 commit intolabd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the issues that seems to have popped up a few times here is that there is no clear way to support multiple audiences with the TokenValidator. This can be a problem when you have a User Pool with more than one client id, which is common for projects that have a REST API for external use.
I had intended to write a new feature branch that would allow for the support of multiple audiences, but as it turns out, there already is support, it's just not documented. So I've added a couple of comments and tests to make it more clear that this is the case.