Make token validation compatible with AccessToken where "aud" claim is not provided#33
Open
martinzugnoni wants to merge 1 commit intolabd:masterfrom
Open
Make token validation compatible with AccessToken where "aud" claim is not provided#33martinzugnoni wants to merge 1 commit intolabd:masterfrom
martinzugnoni wants to merge 1 commit intolabd:masterfrom
Conversation
|
Hi @mikedebock ! Any chance if this issue will be merged to allow optional It seems like Cognito provides As per RFC, this claim should be optional.
I see that the lib was updated last in December 2021. Any chance of adding this feature now and making a release? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described here:
#22
The AccessToken validation is currently broken because the library is mandatorily checking the audience (aud) claim, which is not included in the AccessToken payload.
These few changes should detect it dynamically and check "aud" claim only when it is included in the token.