remote/exporter: add poll tracking override #1625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The poll() function tracks whether the local information has changed vs the previous state and only takes the availability into account. Since we now poll() the resource on creation, the local state is immediately updated with the information on the resource. This also means that instead of a "clear" by sending an unavailable resource, we don't send an update to the coordinator in case the resource is still available. Previously: Create Resource -> unavailable poll() -> update to coordinator Now: create resource, poll() -> availability stays the same and we skip the information update to the coordinator. Add an explicit override to the poll function to mark the state as dirty for the first poll(). Signed-off-by: Rouven Czerwinski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
========================================
- Coverage 55.8% 55.8% -0.1%
========================================
Files 170 170
Lines 13382 13381 -1
========================================
- Hits 7469 7468 -1
Misses 5913 5913
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The poll() function tracks whether the local information has changed vs the previous state and only takes the availability into account. Since we now poll() the resource on creation, the local state is immediately updated with the information on the resource. This also means that instead of a "clear" by sending an unavailable resource, we don't send an update to the coordinator in case the resource is still available.
Previously:
Create Resource -> unavailable
poll() -> update to coordinator
Now:
create resource, poll() -> availability stays the same and we skip the information update to the coordinator.
Add an explicit override to the poll function to mark the state as dirty for the first poll().
Checklist