-
Notifications
You must be signed in to change notification settings - Fork 3
Feature logger open file explorer (LJLogM v1.13, LJStreamM v1.14) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjarman28
wants to merge
32
commits into
develop
Choose a base branch
from
feature-logger-open-file-explorer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjarman28
commented
Jul 1, 2025
- Added a button to open the current working directory in Windows File Explorer
- Update logger GUIs. Note: the controls themselves were not changed, but the icons for the controls were significantly modified.
- Change default logger graph precision to 9 digits.
Added a (folder icon) button to the config panel which opens Windows File Explorer at the current working directory.
It was part of the configuration panel. I also rearranged some of the front panel items.
Created a custom control with a cog icon for the configuration button. Renamed the configuration button 'More Configs'. Shortened the length of the folder icon for the open file explorer button.
They were changed when the control GUI elements were updated.
LJLogM v1.13, LJStreamM v1.14
…e VIs. * Fixed issue where very small readings were being displayed with scientific notation. * Made it so the custom number control allows different representations (not a typdef). * Made it so we can add in a config for logging value precision. Right now, logging uses a precision of 6 digits.
Now there is a program config button and a device state config button.
* Renamed the device state configuration button 'Device Config' and program configuration button 'Program Config'. * Updated the GUI for the two new config panels so their style is similar to Kipling. * Fixed a bug where clicking the 'Save Program Config' button displays a 'saved config' message instead of cancellation message when the cancel button is pressed. * Fixed a bug where clicking the 'Load Program Config' button and cancelling returns a bad config message. * Added messages to the program config panel when the 'Change Working Directory' button is pressed. * Changed the current device connection to display 'Opening...' while a new device connection is trying to be opened (after pressing the open new connection button).
* Removed pop-ups if the initial device open fails. Instead there is a message to go to the device config panel to open a new connection in the error message. * Changed 'currently open device' strings to display 'Not connected' on error.
This subVI specifically toggles on LJM device open errors. This was added to help highlight the device config button when a device open fails so users are more likely to click it and open a new device connection.
Fixed issue where controls were not disabled properly if log to file is enabled at startup.
Added code 1227 (7227) that I previously missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.