fix(BA-650): Ensure unique values in mount list of compute session #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
.fix.md -> 3593.fix.md Co-authored-by: octodog <[email protected]>
5 tasks
fregataa
approved these changes
Feb 6, 2025
rapsealk
changed the title
HyeockJinKim
deleted the
fix/BA-650-duplicated-mount-list-in-compute-session
branch
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
…3593) Co-authored-by: octodog <[email protected]>
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
…3593) Co-authored-by: octodog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3592 (BA-650)
This pull request includes changes to ensure unique values in the compute session mount list and updates the code to use sets instead of lists for mounts in two files.
Code updates:
src/ai/backend/manager/models/session.py: Changed themountsfield in theparse_rowmethod to use a set instead of a list.src/ai/backend/manager/registry.py: Updated themountsfield in theenqueue_sessionmethod to use a set instead of a list.Checklist: (if applicable)
Refs