Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BA-690): Make CSP configurable #3682

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat(BA-690): Make CSP configurable #3682

merged 3 commits into from
Feb 13, 2025

Conversation

HyeockJinKim
Copy link
Collaborator

resolves #3644 (BA-690)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@HyeockJinKim HyeockJinKim self-assigned this Feb 13, 2025
Base automatically changed from feat/add-selector-for-security-policy to main February 13, 2025 03:12
@HyeockJinKim HyeockJinKim changed the title feat: Make security policy configurable feat(BA-690): Make CSP configurable Feb 13, 2025
@HyeockJinKim HyeockJinKim force-pushed the feat/add-config-for-security-policy branch from d145d1b to 76bc254 Compare February 13, 2025 03:14
@github-actions github-actions bot added comp:webserver Related to Web Server component size:M 30~100 LoC labels Feb 13, 2025
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Feb 13, 2025
@HyeockJinKim HyeockJinKim added this to the 24.09 milestone Feb 13, 2025
Merged via the queue into main with commit 9633576 Feb 13, 2025
20 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/add-config-for-security-policy branch February 13, 2025 03:31
lablup-octodog pushed a commit that referenced this pull request Feb 13, 2025
@HyeockJinKim
feat(BA-690): Make CSP configurable (#3682)
a167b0c 
Backported-from: main (25.2)
Backported-to: 24.09
Backport-of: 3682
@lablup-octodog lablup-octodog mentioned this pull request Feb 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
@lablup-octodog @HyeockJinKim
feat(BA-690): Make CSP configurable (#3682) (#3684)
e9684da 
Co-authored-by: HyeockJinKim <[email protected]>
Co-authored-by: HyeockJinKim <[email protected]>
@agatha197 agatha197 mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol Awaiting requested review from achimnol

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@HyeockJinKim HyeockJinKim

Labels
comp:webserver Related to Web Server component size:M 30~100 LoC
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.

Allow configurable connect-src in CSP settings to address proxy and file upload issues
1 participant
@HyeockJinKim