fix: update image output handling in release.yml #391
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
.github/workflows/release.yml
Outdated
| - name: cache images | ||
| working-directory: core/deploy | ||
| run: | | ||
| sudo sealos login -u "${{ github.repository_owner }}" -p "${{ secrets.GITHUB_TOKEN }}" ghcr.io | ||
| sed -i "s#${{ env.GHCR_REPO }}:latest#${{ env.GHCR_REPO }}:${{ steps.meta.outputs.version }}#g" manifests/deploy.yaml.tmpl | ||
| sudo sealos registry save --registry-dir=registry_amd64 --arch amd64 . |
There was a problem hiding this comment.
In the release-sealos-images job the “cache images” step rewrites manifests/deploy.yaml.tmpl using ${{ steps.meta.outputs.version }}, but the meta step is defined later in the job. At runtime this output is empty, so the sed replacement produces image references like ghcr.io/<repo>: and sealos registry save will fail with an invalid reference format. Run the metadata action before this step or reuse the version generated in the previous job before editing the manifest.
Useful? React with 👍 / 👎.
cuisongliu
force-pushed
the
fix-cluster-images
branch
3 times, most recently
from
8f6b625 to
43ce187
Compare
cuisongliu
force-pushed
the
fix-cluster-images
branch
5 times, most recently
from
cf7e774 to
9df5f2c
Compare
cuisongliu
force-pushed
the
fix-cluster-images
branch
from
9df5f2c to
4bc38be
Compare
|
To use Codex here, create an environment for this repo. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
.github/workflows/release.yml
Outdated
| GHCR_REPO: ghcr.io/${{ github.repository }} | ||
| ALIYUN_REGISTRY: ${{ secrets.ALIYUN_REGISTRY }} | ||
| ALIYUN_REPO: ${{ secrets.ALIYUN_REPO != '' && secrets.ALIYUN_REPO || secrets.ALIYUN_USERNAME != '' && format('{0}/{1}/{2}', secrets.ALIYUN_REGISTRY, secrets.ALIYUN_USERNAME, 'aiproxy') || '' }} | ||
| ALIYUN_REPO: ${{ secrets.ALIYUN_REPO != '' && secrets.ALIYUN_REPO || (secrets.ALIYUN_REGISTRY != '' && secrets.ALIYUN_USERNAME != '' && format('{0}/{1}/{2}', secrets.ALIYUN_REGISTRY, secrets.ALIYUN_USERNAME, 'aiproxy')) || '' }} |
There was a problem hiding this comment.
it as ${{ secrets.ALIYUN_REPO != '' && secrets.ALIYUN_REPO || (secrets.ALIYUN_REGISTRY != '' && secrets.ALIYUN_USERNAME != '') && format('{0}/{1}/{2}', secrets.ALIYUN_REGISTRY, secrets.ALIYUN_USERNAME, 'aiproxy') || '' }} better conforms to the && || syntax.
There was a problem hiding this comment.
2 participants
This pull request introduces improvements to the release workflow and deployment process, focusing on better handling of image targets, enhanced support for multi-architecture images, and the addition of a dedicated job for building and pushing Sealos images. It also adds a new installation script and refines deployment scripts for more robust configuration handling.
Release workflow enhancements:
.github/workflows/release.yml). [1] [2]ALIYUN_REPOenvironment variable to ensure correct formatting when registry and username secrets are present (.github/workflows/release.yml).Sealos image support and multi-architecture builds:
release-sealos-imagesjob to the workflow, which builds and pushes cluster images for multiple platforms (amd64 and arm64), and includes improved login steps for various registries (.github/workflows/release.yml).Kubefileto support multi-architecture builds by using platform-specific registry directories and theTARGETARCHbuild argument (core/deploy/Kubefile).Deployment and installation improvements:
.github/scripts/install.sh).cloudDomainconfiguration, ensuring ingress resources are created only when the domain is specified (core/deploy/scripts/init.sh).