Skip to content

Fix the deprecation comment format #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the deprecation comment format #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ type Metric struct {
Buckets []float64
}

// Prometheus contains the metrics gathered by the instance and its path
// Prometheus contains the metrics gathered by the instance and its path.
//
// Deprecated: use echoprometheus package instead
type Prometheus struct {
reqCnt *prometheus.CounterVec
Expand Down Expand Up @@ -175,7 +176,8 @@ type PushGateway struct {
Job string
}

// NewPrometheus generates a new set of metrics with a certain subsystem name
// NewPrometheus generates a new set of metrics with a certain subsystem name.
//
// Deprecated: use echoprometheus package instead
func NewPrometheus(subsystem string, skipper middleware.Skipper, customMetricsList ...[]*Metric) *Prometheus {
var metricsList []*Metric
Expand Down Expand Up @@ -301,7 +303,8 @@ func (p *Prometheus) startPushTicker() {
}()
}

// NewMetric associates prometheus.Collector based on Metric.Type
// NewMetric associates prometheus.Collector based on Metric.Type.
//
// Deprecated: use echoprometheus package instead
func NewMetric(m *Metric, subsystem string) prometheus.Collector {
var metric prometheus.Collector
Expand Down