Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests for arm64 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aderouineau
Copy link

All tests for "EB" fail on arm64:

--- FAIL: TestBytesParse (0.00s)
    bytes_test.go:211:
        	Error Trace:	bytes_test.go:211
        	Error:      	Should be true
        	Test:       	TestBytesParse
    bytes_test.go:215:
        	Error Trace:	bytes_test.go:215
        	Error:      	Should be true
        	Test:       	TestBytesParse
    bytes_test.go:221:
        	Error Trace:	bytes_test.go:221
        	Error:      	Should be true
        	Test:       	TestBytesParse
    bytes_test.go:225:
        	Error Trace:	bytes_test.go:225
        	Error:      	Should be true
        	Test:       	TestBytesParse

This is because the conversion from float64 to int64 is implementation specific (see golang/go#45588). The test on arm64 should be b == math.MaxInt64.

This change moves the "EB" tests in platform-specific test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants