fix: exposed generic functionality to be re-used

[juancappi]

No description provided.

[jurossiar]

LGTM

[jurossiar]

Could you also expose this to be re-used too?
VENV_DIR=be/.venv
VENV_PYTHON=$(VENV_DIR)/bin/python

[juancappi]

Could you also expose this to be re-used too? VENV_DIR=be/.venv VENV_PYTHON=$(VENV_DIR)/bin/python

Yes, but probably not worth the extra complexity. Spent some time trying to do the same we did for check-env but turns out they work quite differently and the same pattern can't be applied for those variables. check-venv works because it’s invoked at run time; we only need it when a target executes. VENV_DIR/VENV_PYTHON are different, because Make needs those values during parse time to expand other targets and variables. For what I found, there is no way to “call” a target in another Makefile and get a variable back before parsing finishes. There is a way to make it work, but involves moving those two assignments into a an .mk file, which would be shared by both Makefiles