Skip to content

Fix empty table issues #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakeshJn merged 2 commits into from
Dec 12, 2025
Merged

Fix empty table issues #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5cb31
Merge pull request #10 from lakevision-project/main
codrut20 Nov 28, 2025
61834b4
fix results and display of empty data
codrut20 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion be/app/lakeviewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,16 @@ def load_table(self, table_id: str):

def get_partition_data(self, table):
#table = self.catalog.load_table(table_id)
if not table.metadata.current_snapshot_id:
return pd.DataFrame()
pa_partitions = table.inspect.partitions()
if pa_partitions.num_rows >1:
pa_partitions = pa_partitions.sort_by([('partition', 'ascending')])
return pa_partitions.to_pandas()

def get_snapshot_data(self, table):
if not table.metadata.current_snapshot_id:
return []
return pd.DataFrame()
pa_snaps = table.inspect.snapshots().sort_by([('committed_at', 'descending')])
df = pa_snaps.to_pandas()
df['committed_at'] = df['committed_at'].apply(lambda x: x.strftime('%Y-%m-%d %H:%M:%S'))
Expand Down
10 changes: 9 additions & 1 deletion fe/src/routes/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@
let snapshots_loading = false;
let sample_data = [];
let sample_data_loading = false;
let sample_data_fetched = false;
let schema = [];
let schema_loading = false;
let summary = [];
Expand Down Expand Up @@ -768,6 +769,7 @@
if (myReq === sampleReq) {
sample_data = data;
lastSampleLimit = $sample_limit;
sample_data_fetched = true;
}
} catch (err) {
if (myReq === sampleReq) {
Expand All @@ -779,7 +781,7 @@
}
}
}
$: if (selected === 3 && tableKey && !sample_data_loading && (sample_data.length === 0 || $sample_limit !== lastSampleLimit)) {
$: if (selected === 3 && tableKey && !sample_data_loading && (!sample_data_fetched || $sample_limit !== lastSampleLimit)) {
fetchSampleData();
}
$: if (tableKey && selected == 0) {
Expand Down Expand Up @@ -947,6 +949,7 @@
url = url + '/?namespace=' + namespace + '&table=' + table + '&sample_limit=' + $sample_limit;
}
function reset(table) {
sample_data_fetched = false;
lastSampleLimit = null;
partitions = [];
snapshots = [];
Expand Down Expand Up @@ -1252,6 +1255,8 @@
/>
<br />
Total items: {partitions.length}
{:else}
No data
{/if}
</TabContent>
<TabContent
Expand Down Expand Up @@ -1303,6 +1308,9 @@
/>
<br />
Sample items: {sample_data.length}
{:else}
<br />
No data
{/if}
</TabContent>
<TabContent>
Expand Down