Skip to content

Conversation

jrchatruc
Copy link
Collaborator

Motivation

Our idea is to take rocksdb options from a file instead of hardcoding them. This is the first step in doing that, in order to use a file we need a change to the rust rocksdb repo for which we've made a PR.

Description

Closes #issue_number

@jrchatruc jrchatruc requested a review from a team as a code owner October 1, 2025 17:44
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 1, 2025
Copy link

github-actions bot commented Oct 1, 2025

Lines of code report

Total lines added: 0
Total lines removed: 84
Total lines changed: 84

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1056  | -84  |
+-------------------------------------------+-------+------+

@Oppen
Copy link
Contributor

Oppen commented Oct 1, 2025

There's a missing commit that contains the "real" defaults that the RocksDB team doesn't impose due to fear of breaking existing deploys.

@rodrigo-o
Copy link
Collaborator

There's a missing commit that contains the "real" defaults that the RocksDB team doesn't impose due to fear of breaking existing deploys.

So this PR still needs some change @Oppen or that's for a follow-up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: No status
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants