fix(l1): added error for case where system contract code is empty

crates/vm/backends/levm/mod.rs

@@ -4,7 +4,7 @@ mod tracing;
 use super::BlockExecutionResult;
 use crate::system_contracts::{
     BEACON_ROOTS_ADDRESS, CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS, HISTORY_STORAGE_ADDRESS,
-    SYSTEM_ADDRESS, WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
+    SYSTEM_ADDRESS, SYSTEM_CONTRACTS_WITH_CODE, WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
 };
 use crate::{EvmError, ExecutionResult};
 use bytes::Bytes;
@@ -381,6 +381,18 @@ pub fn generic_system_contract_levm(
         ..Default::default()
     };
 
+    // This check is not necessary in practice, since contract deployment has succesfully happened in all relevant testnets and mainnet
+    // However, it's necessary to pass some of the Hive tests related to system contract deployment, which is why we have it
+    if SYSTEM_CONTRACTS_WITH_CODE
+        .iter()
+        .any(|contract| contract.address == contract_address)
+        && db.get_account_code(contract_address)?.is_empty()
+    {
+        return Err(EvmError::SystemContractCallFailed(format!(
+            "System contract: {contract_address} has no code after deployment"
+        )));
+    };
+
     let tx = &Transaction::EIP1559Transaction(EIP1559Transaction {
         to: TxKind::Call(contract_address),
         value: U256::zero(),

crates/vm/levm/src/errors.rs

@@ -96,8 +96,10 @@ pub enum TxValidationError {
         priority_fee: U256,
         max_fee_per_gas: U256,
     },
-    #[error("Intrinsic gas too low")]
+    #[error("Transaction gas limit lower than the minimum gas cost to execute the transaction")]
     IntrinsicGasTooLow,
+    #[error("Transaction gas limit lower than the gas cost floor for calldata tokens")]
+    IntrinsicGasBelowFloorGasCost,
     #[error(
         "Gas allowance exceeded. Block gas limit: {block_gas_limit}, transaction gas limit: {tx_gas_limit}"
     )]

crates/vm/levm/src/hooks/default_hook.rs

@@ -11,8 +11,6 @@ use crate::{
 use bytes::Bytes;
 use ethrex_common::{Address, U256, types::Fork};
 
-use std::cmp::max;
-
 pub const MAX_REFUND_QUOTIENT: u64 = 5;
 
 pub struct DefaultHook;
@@ -248,6 +246,10 @@ pub fn validate_min_gas_limit(vm: &mut VM<'_>) -> Result<(), VMError> {
     let calldata = vm.current_call_frame.calldata.clone();
     let intrinsic_gas: u64 = vm.get_intrinsic_gas()?;
 
+    if vm.current_call_frame.gas_limit < intrinsic_gas {
+        return Err(TxValidationError::IntrinsicGasTooLow.into());
+    }
+
     // calldata_cost = tokens_in_calldata * 4
     let calldata_cost: u64 = gas_cost::tx_calldata(&calldata)?;
 
@@ -261,9 +263,8 @@ pub fn validate_min_gas_limit(vm: &mut VM<'_>) -> Result<(), VMError> {
         .checked_add(TX_BASE_COST)
         .ok_or(InternalError::Overflow)?;
 
-    let min_gas_limit = max(intrinsic_gas, floor_cost_by_tokens);
-    if vm.current_call_frame.gas_limit < min_gas_limit {
-        return Err(TxValidationError::IntrinsicGasTooLow.into());
+    if vm.current_call_frame.gas_limit < floor_cost_by_tokens {
+        return Err(TxValidationError::IntrinsicGasBelowFloorGasCost.into());
     }
 
     Ok(())

crates/vm/system_contracts.rs

@@ -69,3 +69,9 @@ pub fn system_contracts_for_fork(fork: Fork) -> impl Iterator<Item = SystemContr
         .into_iter()
         .filter(move |system_contract| system_contract.active_since_fork <= fork)
 }
+
+pub const SYSTEM_CONTRACTS_WITH_CODE: [SystemContract; 3] = [
+    DEPOSIT_CONTRACT_ADDRESS,
+    WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
+    CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS,
+];

tooling/ef_tests/blockchain/deserialize.rs

@@ -40,7 +40,7 @@ where
                     )
                 }
                 "TransactionException.INTRINSIC_GAS_TOO_LOW" => {
-                    BlockChainExpectedException::TxtException("Intrinsic gas too low".to_string())
+                    BlockChainExpectedException::TxtException("Transaction gas limit lower than the minimum gas cost to execute the transaction".to_string())
                 }
                 "TransactionException.INSUFFICIENT_ACCOUNT_FUNDS" => {
                     BlockChainExpectedException::TxtException(

tooling/ef_tests/state/deserialize.rs

@@ -41,6 +41,9 @@ where
                     "TransactionException.INTRINSIC_GAS_TOO_LOW" => {
                         TransactionExpectedException::IntrinsicGasTooLow
                     }
+                    "TransactionException.INTRINSIC_BELOW_FLOOR_GAS_COST" => {
+                        TransactionExpectedException::IntrinsicGasBelowFloorGasCost
+                    }
                     "TransactionException.INSUFFICIENT_ACCOUNT_FUNDS" => {
                         TransactionExpectedException::InsufficientAccountFunds
                     }

tooling/ef_tests/state/runner/levm_runner.rs

@@ -309,6 +309,9 @@ fn exception_is_expected(
             (
                 TransactionExpectedException::IntrinsicGasTooLow,
                 VMError::TxValidation(TxValidationError::IntrinsicGasTooLow)
+            ) | (
+                TransactionExpectedException::IntrinsicGasBelowFloorGasCost,
+                VMError::TxValidation(TxValidationError::IntrinsicGasBelowFloorGasCost)
             ) | (
                 TransactionExpectedException::InsufficientAccountFunds,
                 VMError::TxValidation(TxValidationError::InsufficientAccountFunds)

tooling/ef_tests/state/types.rs

@@ -156,6 +156,7 @@ pub enum TransactionExpectedException {
     Type3TxInvalidBlobVersionedHash,
     Type4TxContractCreation,
     IntrinsicGasTooLow,
+    IntrinsicGasBelowFloorGasCost,
     InsufficientAccountFunds,
     SenderNotEoa,
     PriorityGreaterThanMaxFeePerGas,

tooling/ef_tests/state_v2/src/modules/deserialize.rs

@@ -38,6 +38,9 @@ where
                     "TransactionException.INTRINSIC_GAS_TOO_LOW" => {
                         TransactionExpectedException::IntrinsicGasTooLow
                     }
+                    "TransactionException.INTRINSIC_GAS_BELOW_FLOOR_GAS_COST" => {
+                        TransactionExpectedException::IntrinsicGasBelowFloorGasCost
+                    }
                     "TransactionException.INSUFFICIENT_ACCOUNT_FUNDS" => {
                         TransactionExpectedException::InsufficientAccountFunds
                     }

tooling/ef_tests/state_v2/src/modules/result_check.rs

@@ -160,6 +160,9 @@ fn exception_matches_expected(
             (
                 TransactionExpectedException::IntrinsicGasTooLow,
                 VMError::TxValidation(TxValidationError::IntrinsicGasTooLow)
+            ) | (
+                TransactionExpectedException::IntrinsicGasBelowFloorGasCost,
+                VMError::TxValidation(TxValidationError::IntrinsicGasBelowFloorGasCost)
             ) | (
                 TransactionExpectedException::InsufficientAccountFunds,
                 VMError::TxValidation(TxValidationError::InsufficientAccountFunds)

tooling/ef_tests/state_v2/src/modules/types.rs

@@ -447,6 +447,7 @@ pub enum TransactionExpectedException {
     Type3TxInvalidBlobVersionedHash,
     Type4TxContractCreation,
     IntrinsicGasTooLow,
+    IntrinsicGasBelowFloorGasCost,
     InsufficientAccountFunds,
     SenderNotEoa,
     PriorityGreaterThanMaxFeePerGas,