fix(l1): added error for case where system contract code is empty

crates/vm/backends/levm/mod.rs

@@ -4,7 +4,7 @@ mod tracing;
 use super::BlockExecutionResult;
 use crate::system_contracts::{
     BEACON_ROOTS_ADDRESS, CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS, HISTORY_STORAGE_ADDRESS,
-    SYSTEM_ADDRESS, WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
+    SYSTEM_ADDRESS, SYSTEM_CONTRACTS_WITH_CODE, WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
 };
 use crate::{EvmError, ExecutionResult};
 use bytes::Bytes;
@@ -381,6 +381,18 @@ pub fn generic_system_contract_levm(
         ..Default::default()
     };
 
+    // This check is not necessary in practice, since contract deployment has succesfully happened in all relevant testnets and mainnet
+    // However, it's necessary to pass some of the Hive tests related to system contract deployment, which is why we have it
+    if SYSTEM_CONTRACTS_WITH_CODE
+        .iter()
+        .any(|contract| contract.address == contract_address)
+        && db.get_account_code(contract_address)?.is_empty()
+    {
+        return Err(EvmError::SystemContractCallFailed(format!(
+            "System contract: {contract_address} has no code after deployment"
+        )));
+    };
+
     let tx = &Transaction::EIP1559Transaction(EIP1559Transaction {
         to: TxKind::Call(contract_address),
         value: U256::zero(),

crates/vm/system_contracts.rs

@@ -69,3 +69,9 @@ pub fn system_contracts_for_fork(fork: Fork) -> impl Iterator<Item = SystemContr
         .into_iter()
         .filter(move |system_contract| system_contract.active_since_fork <= fork)
 }
+
+pub const SYSTEM_CONTRACTS_WITH_CODE: [SystemContract; 3] = [
+    DEPOSIT_CONTRACT_ADDRESS,
+    WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS,
+    CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS,
+];