fix(blockchain): avoid awaiting under payloads mutex in get_payload #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested changes
Oct 2, 2025
crates/blockchain/payload.rs
Outdated
| .iter() | ||
| .position(|(id, _)| id == &payload_id) | ||
| .ok_or(ChainError::UnknownPayload)?; | ||
| let (_, item) = payloads.remove(idx); |
There was a problem hiding this comment.
Removing the payload would make the following requests find nothing here. We should change the underlying value type in payloads to something that can be safely shared with the payloads map.
There was a problem hiding this comment.
Removing the payload would make the following requests find nothing here. We should change the underlying value type in payloads to something that can be safely shared with the payloads map.
done boss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor get_payload to avoid awaiting while holding the payloads mutex. Previously, the code held the tokio::Mutex across an async join (finishing a payload build task), which could serialize concurrent engine_getPayload calls and cause avoidable stalls. The new flow removes the entry under lock, drops the lock, finishes the task, then re-acquires the lock to reinsert the finished payload at a clamped index. This preserves eviction/order semantics as much as possible while eliminating the await-under-lock hotspot.