Skip to content

Conversation

rodrigo-o
Copy link
Collaborator

Motivation

After a couple of optimization (#4689) we detected a surge of memory consumption during storage requests

Description

What we saw were ~25% of the memory allocated for the request storage ranges
image

This PR chunks the storage request and removes the large memory allocations

@rodrigo-o rodrigo-o changed the base branch from main to merge_optimizations_fast_insert_semaphore October 7, 2025 19:04
Copy link

github-actions bot commented Oct 7, 2025

Lines of code report

Total lines added: 57
Total lines removed: 140
Total lines changed: 197

Detailed view
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs            | 403   | +6   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/peer_handler.rs | 1846  | +48  |
+----------------------------------------------+-------+------+
| ethrex/crates/storage/api.rs                 | 225   | -8   |
+----------------------------------------------+-------+------+
| ethrex/crates/storage/store.rs               | 1430  | -79  |
+----------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/in_memory.rs  | 530   | -23  |
+----------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs    | 1110  | -30  |
+----------------------------------------------+-------+------+
| ethrex/tooling/reorgs/src/simulator.rs       | 468   | +3   |
+----------------------------------------------+-------+------+

Base automatically changed from merge_optimizations_fast_insert_semaphore to main October 8, 2025 15:43
@rodrigo-o rodrigo-o changed the base branch from main to merge_optimizations_fast_insert_semaphore October 8, 2025 17:53
@github-actions github-actions bot added the L1 Ethereum client label Oct 8, 2025
@rodrigo-o rodrigo-o changed the base branch from merge_optimizations_fast_insert_semaphore to main October 8, 2025 18:03
@rodrigo-o
Copy link
Collaborator Author

Closed in favor of #4821

@rodrigo-o rodrigo-o closed this Oct 8, 2025
@github-project-automation github-project-automation bot moved this to Done in ethrex_l1 Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 Ethereum client
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants