chore(l1): reduce log spam when building blocks #4747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces logging verbosity for block building operations by changing frequently occurring log messages from info to debug level. The motivation is to address log spam that occurred after implementing asynchronous block building that runs multiple times per slot.
- Changed metric logging from
infotodebuglevel in payload building operations - Reduced error logging verbosity for transaction execution failures
- Added TODO comments to indicate these metrics should be exposed as proper metrics
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/l2/sequencer/block_producer/payload_builder.rs | Added TODO comments for future metric implementation |
| crates/blockchain/payload.rs | Changed tracing::info! to tracing::debug! for payload building metrics and transaction error logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fmoletta
approved these changes
Oct 3, 2025
mpaulucci
approved these changes
Oct 6, 2025
Peponks9
pushed a commit
to Peponks9/ethrex
that referenced
this pull request
Oct 7, 2025
**Motivation** When we changed block building to be done asynchronously and multiple times per slot, we kept metrics logs, which ended up being too spammy. **Description** This PR reduces the logs to `debug` level. Closes lambdaclass#4719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we changed block building to be done asynchronously and multiple times per slot, we kept metrics logs, which ended up being too spammy.
Description
This PR reduces the logs to
debuglevel.Closes #4719