Skip to content

refactor(l1): remove unneeded add_transaction_location & add_transaction_locations db methods #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

refactor(l1): remove unneeded add_transaction_location & add_transaction_locations db methods #4765

merged 1 commit into from
Oct 7, 2025

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Oct 3, 2025

Closes #4748

@github-actions github-actions bot added the L1 Ethereum client label Oct 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

Lines of code report

Total lines added: 0
Total lines removed: 148
Total lines changed: 148

Detailed view 
+---------------------------------------------+-------+------+
| File                                        | Lines | Diff |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/api.rs                | 222   | -11  |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store.rs              | 1430  | -79  |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/in_memory.rs | 527   | -26  |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs   | 1108  | -32  |
+---------------------------------------------+-------+------+

@fmoletta fmoletta marked this pull request as ready for review October 3, 2025 19:52
@fmoletta fmoletta requested a review from a team as a code owner October 3, 2025 19:52
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 3, 2025
@mpaulucci mpaulucci added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit 50676ba Oct 7, 2025
42 checks passed
@mpaulucci mpaulucci deleted the remove-add-tx-locations branch October 7, 2025 17:18
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@fmoletta fmoletta

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove superflous add_transaction_location storage functions

3 participants

@fmoletta @mpaulucci @MegaRedHand