ci(l1): fix "Unknown job" job message when workflow fails. #5089
+73
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the resilience and error handling of GitHub Actions workflows. The changes prevent matrix job failures from canceling other jobs and enhance the failure alert system to handle workflow retries more accurately.
- Added
fail-fast: falseto the daily snapsync workflow to allow all matrix jobs to run independently - Refactored the failure alert script to fetch jobs per attempt with fallback logic for better retry handling
- Switched from pagination utility to manual pagination for more control over job collection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/daily_snapsync.yaml |
Added fail-fast: false strategy to prevent matrix job cancellation |
.github/workflows/common_failure_alerts.yaml |
Refactored job collection logic to support per-attempt job fetching with fallback and manual pagination |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpaulucci
changed the title
fedacking
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All failing workflows are showing "Unknown job" in Slack message
Description
The culprit was how we gathered the job list: we queried the generic listJobsForWorkflowRun, which sometimes returns an empty set for the latest attempt of a run. By switching to the attempt-specific endpoint and paging it ourselves, the script now pulls the jobs that actually failed before formatting the message, so the alert should finally show the real job names instead of defaulting to “Unknown job.”