refactor(l1,l2): extract duplicate witness generation logic to helper#5905
Open
Itodo-S wants to merge 6 commits intolambdaclass:mainfrom
Open
refactor(l1,l2): extract duplicate witness generation logic to helper#5905Itodo-S wants to merge 6 commits intolambdaclass:mainfrom
Itodo-S wants to merge 6 commits intolambdaclass:mainfrom
Conversation
azteca1998
approved these changes
Jan 22, 2026
ElFantasma
approved these changes
Feb 11, 2026
| ) | ||
| } | ||
|
|
||
| #[allow(clippy::too_many_arguments)] |
Contributor
There was a problem hiding this comment.
nit: 8 parameters is a lot. If more get added in the future, consider bundling some of these into a WitnessContext struct (e.g., first_block_header, last_block_header, witness_first_block_number, initial_state_root). Not necessary for this PR.
Author
There was a problem hiding this comment.
That's a great observation. noted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Both functions shared a significant amount of identical code for reconstructing partial tries and fetching block headers. This refactor reduces maintenance burden and improves code readability.
Description
Extracted the duplicated witness generation logic from [generate_witness_for_blocks_with_fee_configs] and [generate_witness_from_account_updates] into a new helper function [construct_execution_witness]
Changes
Verification
cargo test -p ethrex-blockchainto ensure no regressions were introduced.Closes #5708