Skip to content

chore: fix typo in 'succesful_downloads' to 'successful_downloads'#6204

Open
gap-editor wants to merge 2 commits intolambdaclass:mainfrom
gap-editor:patch-1
Open

chore: fix typo in 'succesful_downloads' to 'successful_downloads'#6204
gap-editor wants to merge 2 commits intolambdaclass:mainfrom
gap-editor:patch-1

Conversation

@gap-editor
Copy link

Motivation

Description

Checklist

  • Updated STORE_SCHEMA_VERSION (crates/storage/lib.rs) if the PR includes breaking changes to the Store requiring a re-sync.

Closes #issue_number

@gap-editor gap-editor requested a review from a team as a code owner February 13, 2026 19:24
@greptile-apps
Copy link

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

This PR fixes a typo in the variable name succesful_downloads to successful_downloads throughout the storage healing module. However, the fix is incomplete - one instance of the old misspelled variable name remains on line 197 in the calculation for successful_downloads_percentage, which will cause a compilation error since the variable succesful_downloads no longer exists.

Confidence Score: 0/5

  • This PR cannot be merged as it contains a critical compilation error
  • The typo fix is incomplete - line 197 still references the old misspelled variable name succesful_downloads, which will cause the code to fail compilation since that variable no longer exists after the rename
  • crates/networking/p2p/sync/healing/storage.rs requires immediate attention to fix the remaining typo on line 197

Important Files Changed

Filename Overview
crates/networking/p2p/sync/healing/storage.rs Typo fix incomplete - one instance of the misspelled variable succesful_downloads remains on line 197, will cause compilation error

Last reviewed commit: fd651bd

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

succesful_downloads_percentage = state.succesful_downloads as f64
successful_downloads = state.successful_downloads,
successful_downloads_percentage = state.successful_downloads as f64
/ (state.succesful_downloads as f64 + state.failed_downloads as f64),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one instance - still using the old misspelled variable name succesful_downloads instead of successful_downloads

Suggested change
/ (state.succesful_downloads as f64 + state.failed_downloads as f64),
/ (state.successful_downloads as f64 + state.failed_downloads as f64),
Prompt To Fix With AI
This is a comment left during a code review.
Path: crates/networking/p2p/sync/healing/storage.rs
Line: 197:197

Comment:
Missed one instance - still using the old misspelled variable name `succesful_downloads` instead of `successful_downloads`

```suggestion
                    / (state.successful_downloads as f64 + state.failed_downloads as f64),
```

How can I resolve this? If you propose a fix, please make it concise.

Co-authored-by: ElFantasma <estebandh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants