feat: assertoor implementation support #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
ElFantasma
reviewed
Jan 31, 2025
ElFantasma
reviewed
Jan 31, 2025
ElFantasma
approved these changes
Jan 31, 2025
Contributor
ElFantasma
left a comment
ElFantasma
left a comment
There was a problem hiding this comment.
LGTM, just a couple of suggestions on English redaction
Co-authored-by: ElFantasma <[email protected]>
Co-authored-by: ElFantasma <[email protected]>
Add a small TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Assertoor will allow us to have better regression checks when we tackle performance refactors
Description
Endpoints that needed fix/implementation for assertoor to work:
node/health- fixednode/syncing- added (semi-stub)beacon/genesis- fixedconfigs/spec- added (semi-stub)headers/head- added (semi-stub)states/head/finality_checkpoints- fixedevents- This was implemented in feat: sse implementation for events beacon API #1365Closes #1323