Add failing test case for factory creation of elements with required options

test/FactoryTest.php

@@ -23,6 +23,7 @@
 use Laminas\Validator\ValidatorChain;
 use Laminas\Validator\ValidatorInterface;
 use Laminas\Validator\ValidatorPluginManager;
+use LaminasTest\Form\TestAsset\CustomElementWithRequiredOption;
 use LaminasTest\Form\TestAsset\InputFilter;
 use LaminasTest\Form\TestAsset\Model;
 use PHPUnit\Framework\TestCase;
@@ -849,4 +850,70 @@ public function testCanCreateWithConstructionLogicInOptions(): void
         self::assertInstanceOf(TestAsset\FieldsetWithDependency::class, $targetElement);
         self::assertInstanceOf(InputFilter::class, $targetElement->getDependency());
     }
+
+    public function testElementWithRequiredOptionsNestedInFieldsetOrCollection(): void
+    {
+        $formManager = $this->factory->getFormElementManager();
+        $formManager->setFactory(
+            TestAsset\FieldsetWithDependency::class,
+            TestAsset\FieldsetWithDependencyFactory::class
+        );
+
+        $collection = $this->factory->create([
+            'type'    => Form\Element\Collection::class,
+            'name'    => 'my_fieldset_collection',
+            'options' => [
+                'target_element' => [
+                    'type'    => CustomElementWithRequiredOption::class,
+                    'options' => [
+                        'requiredOption' => 'Any String',
+                    ],
+                ],
+            ],
+        ]);
+        self::assertInstanceOf(Form\Element\Collection::class, $collection);
+        $element = $collection->getTargetElement();
+        self::assertInstanceOf(CustomElementWithRequiredOption::class, $element);
+        self::assertSame('Any String', $element->myString);
+    }
+
+    public function testCreateElementWithRequiredOption(): void
+    {
+        $element = $this->factory->create([
+            'type'    => CustomElementWithRequiredOption::class,
+            'name'    => 'foo',
+            'options' => [
+                'requiredOption' => 'Any String',
+            ],
+        ]);
+
+        self::assertInstanceOf(CustomElementWithRequiredOption::class, $element);
+        self::assertSame('Any String', $element->myString);
+    }
+
+    public function testCanCreateElementWithConstructorDependency(): void
+    {
+        $formManager = $this->factory->getFormElementManager();
+        $formManager->setFactory(
+            TestAsset\CustomElementWithConstructorDependency::class,
+            TestAsset\CustomElementWithConstructorDependencyFactory::class
+        );
+
+        $collection = $this->factory->create([
+            'type'    => Form\Element\Collection::class,
+            'name'    => 'my_fieldset_collection',
+            'options' => [
+                'target_element' => [
+                    'type' => TestAsset\CustomElementWithConstructorDependency::class,
+                ],
+            ],
+        ]);
+
+        self::assertInstanceOf(Form\Element\Collection::class, $collection);
+
+        $targetElement = $collection->getTargetElement();
+
+        self::assertInstanceOf(TestAsset\CustomElementWithConstructorDependency::class, $targetElement);
+        self::assertSame('FOO', $targetElement->myString);
+    }
 }

test/TestAsset/CustomElementWithConstructorDependency.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Form\TestAsset;
+
+use Laminas\Form\Element\MultiCheckbox;
+
+final class CustomElementWithConstructorDependency extends MultiCheckbox
+{
+    public function __construct(
+        string|null $name = null,
+        iterable $options = [],
+        public readonly string $myString, // phpcs:ignore
+    ) {
+        parent::__construct($name, $options);
+    }
+}

test/TestAsset/CustomElementWithConstructorDependencyFactory.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Form\TestAsset;
+
+use Psr\Container\ContainerInterface;
+
+final class CustomElementWithConstructorDependencyFactory
+{
+    public function __invoke(
+        ContainerInterface $container,
+        string $requestedName,
+        array|null $options = null,
+    ): CustomElementWithConstructorDependency {
+        return new CustomElementWithConstructorDependency(
+            null,
+            $options ?? [],
+            'FOO',
+        );
+    }
+}

test/TestAsset/CustomElementWithRequiredOption.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Form\TestAsset;
+
+use Laminas\Form\Element\MultiCheckbox;
+
+final class CustomElementWithRequiredOption extends MultiCheckbox
+{
+    public readonly string $myString;
+
+    /** @param array<array-key, mixed> $options */
+    public function __construct(string|null $name = null, iterable $options = [])
+    {
+        /**
+         * The null assignment causes a type error which is desired
+         *
+         * @psalm-suppress PossiblyNullPropertyAssignmentValue
+         */
+        $this->myString = $options['requiredOption'] ?? null;
+
+        parent::__construct($name, $options);
+    }
+}