fix(index): support nested field lifecycle#219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds nested field path support across the Lance index lifecycle in DuckDB. It canonicalizes index targets through Lance schema field paths, preserves case-insensitive field resolution, handles escaped literal path segments, and keeps SHOW INDEXES / scanner index selection aligned on canonical nested paths.
The change fixes cases where nested fields with the same leaf name, literal dots, or qualified table references could not be indexed or displayed consistently. It also invalidates the attached-table dataset cache after native CREATE INDEX so follow-up scans can observe the new index metadata.
Validation
uv run make formatcargo fmt --manifest-path Cargo.toml --checkcargo check --manifest-path Cargo.tomlcargo test --manifest-path Cargo.toml ffi::index::testsGEN=ninja make debug./build/debug/test/unittest test/sql/index_ddl.test./build/debug/test/unittest test/sql/scan_index_aware_scanner.test