test: simplify memory tests #5214
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the memory integration tests that used spans with one that tracks general statistics in an custom allocator. Advantages:
Disadvantages:
cargo testwill have failuresAs a side note, I did look into exposing this in Python, so we could use it in Python tests. However, I found it wasn't useful in many cases because it only tracked allocations from the Lance binary. This meant it missed allocations made by PyArrow, for example, so the insertion tests couldn't be written in Python. If we want to do allocation tracking in Python, we will probably have to do something that uses the
LD_PRELOADtrick.