-
Notifications
You must be signed in to change notification settings - Fork 489
feat: add huggingface native support #5353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Xuanwo <[email protected]>
|
thanks for this! looks like some tests have been queued for the past 3 hours or so, is that expected? |
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Yes there are some issues with Github runners right now, we are working on switching to use 3rd party runners |
|
were you already able to test with this public hf dataset @Xuanwo? |
|
@Xuanwo can you rebase main and the CI should work now |
Signed-off-by: Xuanwo <[email protected]>
…control' into Xuanwo/hf-fragment-control
|
Hi, @pavanramkumar, yes, it works!
However, we didn't support |
Signed-off-by: Xuanwo <[email protected]>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Fantastic! I just tested this now and it works. Thank you!
Specifying a revision also works nicely! It's not urgent, but I don't see |

Close #5346
This PR adds native support of huggingface in lance.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.