Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default PHP to 8.3 match Acquia's default #107

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

rubenvarela
Copy link
Collaborator

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for lando-acquia ready!

Name Link
🔨 Latest commit a30a018
🔍 Latest deploy log https://app.netlify.com/sites/lando-acquia/deploys/66ec5f4f84aa1e0008e2c631
😎 Deploy Preview https://deploy-preview-107--lando-acquia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@reynoldsalec reynoldsalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirog normally I'm loathe to update defaults but in this case it seems like a good idea...you cool with this?

@pirog
Copy link
Member

pirog commented Sep 22, 2024

I think in this case its probably fine @reynoldsalec. plus you and @rubenvarela have a better sense of what makes sense on acquia now vs me ;)

@reynoldsalec reynoldsalec merged commit 041a29f into main Sep 23, 2024
20 checks passed
@reynoldsalec reynoldsalec deleted the feature/php-8.3 branch September 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants