Fixes EISDIR corrective action creating new EISDIR errors later #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error I ran into:
Seems some error case gets checked to see if a directory can be created. This is problematic if the
f
getting passed to mkdir is a file name. When there is now a directory with the path and name of one of our files, subsequent runs of this function will attempt to put the file where there is now a directory with the same name. It breaks because unlinking a directory is not possible.I added a function to remove the directory that got created during the mkdir in the conditional above it. It's equivalent to an
rm -rf
so it won't throw a new error iff
doesn't exist.