Update chat_models to support granite with Langchain #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two issues:
role:::: assistant
raw_tool_call:::: {'id': 'chatcmpl-tool-089a4f22f4534962aee2692975da9f3c', 'type': 'function', 'function': {'name': 'ibmcloud_resources', 'arguments': '"{\\n \\"output\\": \\"json\\"\\n}"'}}
raw tool call with which convert str of json to string
content::::
tool_calls:::: [{'name': 'ibmcloud_resources', 'args': '{\n "output": "json"\n}', 'id': 'chatcmpl-tool-089a4f22f4534962aee2692975da9f3c', 'type': 'tool_call'}]
invalid_tool_calls:::: []
Similarly in response It gives a dict string instead of json string
role:::: assistant
raw_tool_call:::: {'id': 'chatcmpl-tool-7b2cd9cbd4904da9b8c787b34056111d', 'type': 'function', 'function': {'name': 'ResponseFormat', 'arguments': "{'message': '*******', 'status': 'completed'}"}}
content::::
tool_calls:::: []
invalid_tool_calls:::: [{'name': 'ResponseFormat', 'args': "{'message': '**********', 'type': 'invalid_tool_call'}]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues while using granite with A2A and langraph:
role:::: assistant
raw_tool_call:::: {'id': 'chatcmpl-tool-089a4f22f4534962aee2692975da9f3c', 'type': 'function', 'function': {'name': 'ibmcloud_resources', 'arguments': '"{\n \"output\": \"json\"\n}"'}}
raw tool call with which convert str of json to string content::::
tool_calls:::: [{'name': 'ibmcloud_resources', 'args': '{\n "output": "json"\n}', 'id': 'chatcmpl-tool-089a4f22f4534962aee2692975da9f3c', 'type': 'tool_call'}] invalid_tool_calls:::: []
Similarly in response It gives a dict string instead of json string
role:::: assistant
raw_tool_call:::: {'id': 'chatcmpl-tool-7b2cd9cbd4904da9b8c787b34056111d', 'type': 'function', 'function': {'name': 'ResponseFormat', 'arguments': "{'message': '', 'status': 'completed'}"}}
content::::
tool_calls:::: []
invalid_tool_calls:::: [{'name': 'ResponseFormat', 'args': "{'message': '***', 'type': 'invalid_tool_call'}]