fix(langchain): bind strict=True only for openai + grok
#33528
+193
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
langchain
sydney-runkle
changed the title
strict=True only for OpenAIstrict=True only for OpenAI
sydney-runkle
changed the title
strict=True only for OpenAIstrict=True only for openai + grok
sydney-runkle
commented
Oct 16, 2025
sydney-runkle
commented
Oct 16, 2025
| SchemaKind = Literal["pydantic", "dataclass", "typeddict", "json_schema"] | ||
|
|
||
|
|
||
| def _supports_provider_strategy(model_name: str) -> bool: |
There was a problem hiding this comment.
this is fickle. should we make it public?
sydney-runkle
commented
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can do more complex things w/
model_nameinto_model_kwargslong term if we support more providers that don't requirestrict=True